Misc authentication #252
Merged
Misc authentication #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- .credential(email, password); - Android/JS: Added auth().link(credential); TODO other providers. @chrisbianca - ios needs doing if you need this / have time =] @Ehesp needs testing
…defined in messaging.js - this now includes all the previously missing options such as ttl and collapse key @chrisbianca / note to self - ios needs doing ;p
|
This looks great!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrisbianca 2nd and 3rd parts need implementing on ios - fairly trivial though as most of the work is done JS side =]