Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom role names #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

miguel-a-calles-mba
Copy link

You can now specify custom role names.

custom:
  serverless-iam-roles-per-function:
    customRoleName: true # defaults to false
    roleNamePrefix: prefix # required if `customRoleName` is true
    roleNameSuffix: suffix # optional

@coveralls
Copy link

coveralls commented Oct 22, 2019

Pull Request Test Coverage Report for Build 134

  • 11 of 12 (91.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 92.07%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/index.ts 11 12 91.67%
Totals Coverage Status
Change from base Build 128: -0.9%
Covered Lines: 375
Relevant Lines: 399

💛 - Coveralls

@nadobando
Copy link

when this will be merged? I want to be able to set the naming convention, so I don't need to make every function role name shorter

@s1mrankaur
Copy link

Any update here?

@miguel-a-calles-mba
Copy link
Author

@s1mrankaur, I stopped using this plugin and stopped worked on this PR. Are you up for working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants