Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single-image-viewer gesture improvements #272

Merged
merged 3 commits into from
Sep 13, 2022
Merged

single-image-viewer gesture improvements #272

merged 3 commits into from
Sep 13, 2022

Conversation

dhruvtailor7
Copy link
Contributor

@dhruvtailor7 dhruvtailor7 commented Sep 2, 2022 •
edited
Loading

PR for issue #262.

Task

  • Scale down the image while pulling it down for closing
  • Prevent scroll while pulling up the info sheet
  • Hide/show the bottom bar and header when tapping (single tap) on the image

@dhruvtailor7
Copy link
Contributor Author

@ghorbani-m Please review the changes.

@ghorbani-m
Copy link
Collaborator

@ghorbani-m Please review the changes.

Thanks @dhruvtailor7 , will check it out, and let you know.

@ghorbani-m
Copy link
Collaborator

Great job @dhruvtailor7 ,

  • I've found a dead-lock situation, please have a look at the below video
  • Could you please animate the buttons and header opacity as well (same as the background opacity) while pulling the image down?
WhatsApp.Video.2022-09-06.at.15.46.58.mp4

@ghorbani-m ghorbani-m merged commit 38a6957 into functionland:develop Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvtailor7 @ghorbani-m