Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to net6.0 #15

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Conversation

jeffward01
Copy link

@jeffward01 jeffward01 commented Sep 24, 2022

Summary

  • Updated all packages to most recent versions
  • Updated target framework from net5.0 --> net6.0

What?

Update of all packages and updated target framework

Why?

Please let me know if any issues, I tested it on my local net6.0 project without any issues. Deeper testing should be done, however, I believe it is stable due to no code changes were made, and only the framework version was updated.

How?

Updated the common.props file (target frameworks, I removed net5 and replaced with net 6) and all nuget packages

Questions to Repository Author

This was a very simple upgrade, is there any reason why this was not done earlier? I feel like it was 'to-easy' and I am overlooking something that perhaps you are aware of.

Thanks

@jeffward01
Copy link
Author

jeffward01 commented Sep 24, 2022

I updated the package to 1.4.1 However, i recommend it is updated to 2.0.0 or perhaps 1.5.0 instead to denote the 'new target framework`

common.props Outdated
<TargetFrameworks>net5.0</TargetFrameworks>
<Version>1.4.0</Version>
<TargetFrameworks>net6.0</TargetFrameworks>
<Version>1.4.1</Version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes do not affect the minor version. Framework changes should be assigned to higher versions.

So use 1.5.0 instead of 1.4.1.
fyi @jeffward01

Copy link
Owner

@furkandeveloper furkandeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes do not affect the minor version. Framework changes should be assigned to higher versions.

So use 1.5.0 instead of 1.4.1.

fyi @jeffward01

@jeffward01
Copy link
Author

@furkandeveloper - done! updated from 1.4.1 to 1.5.0 in the common.props file

Copy link
Owner

@furkandeveloper furkandeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@furkandeveloper
Copy link
Owner

You are right 2.0.0 would be a more appropriate version. @jeffward01

@furkandeveloper furkandeveloper merged commit cb2c28b into furkandeveloper:master Sep 26, 2022
@jeffward01 jeffward01 deleted the net6-upgrade branch September 26, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants