Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC: Adding Week 8 Blogpost #829

Merged
merged 1 commit into from
Jul 30, 2023
Merged

GSoC: Adding Week 8 Blogpost #829

merged 1 commit into from
Jul 30, 2023

Conversation

ganimtron-10
Copy link
Contributor

image

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #829 (7021e63) into master (e595bad) will decrease coverage by 0.10%.
Report is 40 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #829      +/-   ##
==========================================
- Coverage   84.43%   84.33%   -0.10%     
==========================================
  Files          43       44       +1     
  Lines       10274    10356      +82     
  Branches     1393     1410      +17     
==========================================
+ Hits         8675     8734      +59     
- Misses       1239     1252      +13     
- Partials      360      370      +10     

see 3 files with indirect coverage changes

Copy link
Contributor

@tvcastillod tvcastillod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ganimtron-10, the blogpost is generating correctly. Everything looks good to me.

Copy link
Contributor

@JoaoDell JoaoDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ganimtron-10, it built fine here and everything seems ok with the text. Pair programming sessions are indeed a blessing, good you found a way to solve your issues!

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ganimtron-10, merging

@skoudoro skoudoro merged commit 2551b7f into fury-gl:master Jul 30, 2023
21 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants