-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JVM crashes due to systemInstall() when running javaw (no terminal) #216
Comments
Why this issue is closed? Is it already fixed? |
@Stexxe yeah. "Just found out that the user was running the jar without a terminal..." |
Is it expected to crash in this case? |
It should NEVER be ok to crash the JVM IMO. |
@Osiris-Team can you fix it? |
I can reopen, but I dont really care, since it only happens when running the jar without a terminal. |
So... I'm back and I need this fixed, since now its actually causing me trouble ^^ Couldn't it be fixed by checking if we are running without a terminal, before loading the native libs? This should work for Java7+ source and docs: if (System.console() == null) // Running without a terminal, thus do nothing aka return
return; @gnodet |
Soo, I'm back with a working fix! You can use my fork here: https://github.com/Osiris-Team/jansi |
I haven't been able to reproduce exactly the problem, see #265 ... |
Possibly already fixed, since this issue is 2 years old? |
That's the problem. I can't reproduce it with |
@gnodet what do you mean? Can't u simply rename |
I can, but the does not cause any crash. If your fix was correct, i.e. testing I must assume this has been fixed somehow in master. Could you please double check with your environment, as I can't produce any crash... |
@gnodet I just tested it again on my fork with fixes removed and with
I would guess that something fixed it in newer jansi versions. |
@Osiris-Team I think I found the problem. Could you double check with the PR #265 ? |
@gnodet I think you can replicate it by modifying the test to first start a new bash/Powershell terminal then running the Javaw command from there. |
When running the jar without a terminal it crashes.
Show full crash log
The text was updated successfully, but these errors were encountered: