Support using FFM in native-image #269
Conversation
|
The purpose of this PR is to fix #246, but currently building static images will fail. I need to investigate more, maybe because GraalVM doesn't currently support using musl and ffm at the same time? |
|
@gnodet This PR is completed. Unfortunately, it still doesn't solve #246 , so I need to try something else. I refactored In addition, I also made some adjustments so that only the JNI library of the corresponding platform is retained in native-image, and exclude all JNI libraries when users use FFM. But this only works for GraalVM 22.3+, so users of older GraalVM must add the |
|
I have some new ideas for #246, and if this PR is merged, I can try new things based on it. |
| } | ||
|
|
||
| public static AnsiConsoleSupport.Kernel32 getKernel32() { | ||
| if (KERNEL32 == null) { | ||
| if (LibraryHolder.KERNEL32 == null) { | ||
| if (OSInfo.isWindows()) { | ||
| throw new RuntimeException("Unable to get the instance of Kernel32", ERR); |
There was a problem hiding this comment.
I think this should be LibraryHolder.ERR.
On a side note, I'm wondering if we should use singleton patterns (a single static field for the instance holding fields for the variables) for AnsiConsoleSupportHolder and LibraryHolder instead of using a bunch of static fields...
There was a problem hiding this comment.
On a side note, I'm wondering if we should use singleton patterns (a single static field for the instance holding fields for the variables) for
AnsiConsoleSupportHolderandLibraryHolderinstead of using a bunch of static fields...
I converted AnsiConsoleSupport to an abstract class and cached CLibrary and Kernel32 in it.
| @@ -169,7 +182,7 @@ private static String readFully(InputStream in) throws IOException { | |||
| while ((readLen = in.read(buf, 0, buf.length)) >= 0) { | |||
| b.write(buf, 0, readLen); | |||
| } | |||
| return b.toString(); | |||
| return b.toString("UTF-8"); | |||
There was a problem hiding this comment.
StandardCharsets.UTF_8?
ByteArrayOutputStream::toString(Charset) is only available since Java 10, so we cannot use it here.
See: https://www.graalvm.org/latest/reference-manual/native-image/dynamic-features/foreign-interface/
This PR provides FFM support for native-image.
Since FFM support in both JDK 21 and GraalVM is in preview, this PR is also experimental until GraalVM provides stable support for FFM.
Users need to provide the following options to the native-image tool to enable FFM support:
If jansi is on the class path instead of the module path, replace
org.fusesource.jansiwithALL-UNNAMED.This PR is working, but there seems to be some glitch that I still need to look into