Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable service-catalog using oc cluster up option #83

Merged
merged 3 commits into from
Jul 7, 2017

Conversation

cfchase
Copy link
Contributor

@cfchase cfchase commented Jun 28, 2017

Use oc cluster up --service-catalog=true instead of separate service catalog setup.

@jwmatthews
Copy link
Member

Don't forget about when we deploy to ec2 we create SSL certificates then configure oc cluster up to use those certs with the hostname.

Need to be sure that functionality still works, saw a few SSL related tasks were removed, unsure if they were solely for the apiserver of service catalog, or if some of them might enable using a custom ssl cert for the ec2 provisioning.

@cfchase cfchase force-pushed the service-catalog-true branch 2 times, most recently from a1c2f5e to 7a167d7 Compare June 30, 2017 16:15
@cfchase cfchase changed the title [WIP] Service catalog true On local setup - Enable service-catalog using oc cluster up option Jun 30, 2017
@cfchase
Copy link
Contributor Author

cfchase commented Jun 30, 2017

@jwmatthews restored ec2 install using a separate role. I'm still debugging failures when using --service-catalog=true and editing the master-config.yml to use ssl, but this should get websockets working on local installs. Will follow up with ec2 changes in a separate PR.

@jwmatthews
Copy link
Member

Saw success with linux and ec2 (using old behavior)

Saw failure on mac, debugging.

@jwmatthews
Copy link
Member

I saw success on the mac testing.

I needed to:

  • Remove all images
  • Restart laptop

After that worked and saw provision/bind workflow successful.

@jwmatthews
Copy link
Member

ACK

@cfchase cfchase changed the title On local setup - Enable service-catalog using oc cluster up option Enable service-catalog using oc cluster up option Jul 5, 2017
when: ansible_os_family == "RedHat"

- set_fact:
oc_tools_dir: /usr/bin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oc_tools_dir needs to be in the user's path for the oc commands to execute correctly. The other option would be to execute oc commands with a modified environment.PATH variable.

@cfchase
Copy link
Contributor Author

cfchase commented Jul 5, 2017

@johnkim76
Copy link
Contributor

successfully tested this branch

@jwmatthews
Copy link
Member

Doing 1 more run with testing ec2, then will merge if all checks out

@jwmatthews
Copy link
Member

TASK [demo_prep : create rds apb resource file] **********************************************************************************************************************************************************
changed: [34.203.86.190]

TASK [demo_prep : create rds postgres demo instance] *****************************************************************************************************************************************************
fatal: [34.203.86.190]: FAILED! => {"changed": true, "cmd": "/usr/bin/kubectl --kubeconfig=/root/.kube/service-catalog.config create -f /tmp/rds-instance.yml", "delta": "0:00:00.074828", "end": "2017-07-06 17:09:48.501699", "failed": true, "rc": 1, "start": "2017-07-06 17:09:48.426871", "stderr": "error: stat /root/.kube/service-catalog.config: no such file or directory", "stderr_lines": ["error: stat /root/.kube/service-catalog.config: no such file or directory"], "stdout": "", "stdout_lines": []}
to retry, use: --limit @/git/Summit2017/fusor/catasb/ansible/setup_environment.retry

PLAY RECAP ***********************************************************************************************************************************************************************************************
34.203.86.190 : ok=100 changed=72 unreachable=0 failed=1
localhost : ok=2 changed=0 unreachable=0 failed=0

Looks like we need to update one more spot in 'demo_prep' to switch from kubectl to oc and stop using the kube config from service catalog

@jwmatthews
Copy link
Member

I pushed 1 commit to address the prior failure i saw with ec2.
Re-testing on a clean run now

@jwmatthews
Copy link
Member

The SSL cert isn't correct for EC2.
We lost the 'green' connection we had in past.

I suspect SSL configuration is not correct, we should fix before merging.

@jwmatthews jwmatthews self-assigned this Jul 6, 2017
@jwmatthews jwmatthews changed the title Enable service-catalog using oc cluster up option [Do Not Merge] Enable service-catalog using oc cluster up option Jul 6, 2017
dest: "{{ oc_host_config_dir }}/master/master-config.yaml"
insertbefore: "openshift.io/ImagePolicy:"
line: " PodPreset:\n configuration:\n kind: DefaultAdmissionConfig\n apiVersion: v1\n disable: false"
line: " namedCertificates:\n - certFile: /var/lib/origin/openshift.local.config/console-fullchain.pem\n keyFile: /var/lib/origin/openshift.local.config/console-privkey.pem\n names:\n - \"cchase.ec2.dog8code.com\"\n - \"apiserver-service-catalog.cchase.ec2.dog8code.com\""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to remove the 'cchase.*' references.

@@ -128,15 +127,6 @@
- "{{ docker_images_group1 }}"
- "{{ docker_images_group2 }}"

- name: Remove {{ oc_host_config_dir }}/master/master-config.yaml when resetting cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want this block back in, on a reset it helps to be sure we are regenerating the master-config.yaml.
I'm running reset_environment.sh now, and it still has changes in master-config.yaml from prior run.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this back, nothing else needed to be done here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I was confused by this comment. I thought that the intent of the reset was to avoid the extra up/down to generate the config. If we want to generate a new config every time, should we just do the extra up/down any time we use a custom config?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original context was catasb only worked on ec2 provisioning.
reset was intended to reuse the provisioned instance, just reset the oc cluster portion.

Then we added in the local options, so reset became much closer to setup_local_environment, not sure off hand what the diffs are if there are any on local context.

Essentially we want reset to be capable of clearing out the prior config and resetting from scratch.

@jwmatthews
Copy link
Member

I made changes and am seeing success with the cert now.
I'll push up a commit shortly.

also removed some unused pieces from the service catalog apiserver
now being behind the api aggregator
@jwmatthews jwmatthews changed the title [Do Not Merge] Enable service-catalog using oc cluster up option Enable service-catalog using oc cluster up option Jul 6, 2017
@jwmatthews
Copy link
Member

I pushed some changes, seeing good results with ec2 now.

Doing one more pass of a clean setup of ec2, and checking local linux again.

@jwmatthews
Copy link
Member

@cfchase this is all good on my end.
Went back and retested EC2 and local linux.

I'm good to merge this in now, assuming you are OK with the 2 commits I added.

@cfchase
Copy link
Contributor Author

cfchase commented Jul 7, 2017

@jwmatthews thanks for the fixes.

@cfchase cfchase merged commit 12e3133 into dev Jul 7, 2017
@cfchase cfchase deleted the service-catalog-true branch July 7, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants