Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/initialize backend #1

Closed
wants to merge 3 commits into from
Closed

Feat/initialize backend #1

wants to merge 3 commits into from

Conversation

vade123
Copy link
Collaborator

@vade123 vade123 commented Sep 2, 2024 •
edited
Loading

  • local dev env for azure functions with a dummy health check func
  • local mongodb
  • somewhat sensible eslint, prettier and ts configs based on previous projects

skumpulainen
skumpulainen approved these changes Sep 4, 2024
View reviewed changes
backend/tsconfig.json
"allowSyntheticDefaultImports": true,
"declaration": false,
"esModuleInterop": true,
"experimentalDecorators": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

front end can definitely share some of these. I would probably add noUnusedLocals and noUnusedParameters

backend/prettier.config.js
@@ -0,0 +1,4 @@
module.exports = {
semi: false,
printWidth: 100,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could add "bracketSpacing": true and "bracketSameLine": false

backend/README.md
```bash
$ npm install
$ npm start
```
Copy link
Collaborator

@skumpulainen skumpulainen Sep 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here could be some optional instructions to activate the correct node version via local .nvmrc, for example using nvm.

@hollannikas hollannikas marked this pull request as draft September 14, 2024 12:15
@hollannikas
Copy link
Collaborator

hollannikas commented Sep 14, 2024 •
edited
Loading

Converted to draft while looking into this azd template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skumpulainen skumpulainen skumpulainen approved these changes

@Kitsupitsu Kitsupitsu Kitsupitsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vade123 @hollannikas @Kitsupitsu @skumpulainen