Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to build 1.0, bson.h not found [FreeBSD 12.1] #200

Closed
afhp-2020 opened this issue Sep 3, 2020 · 6 comments · Fixed by #207
Closed

Unable to build 1.0, bson.h not found [FreeBSD 12.1] #200

afhp-2020 opened this issue Sep 3, 2020 · 6 comments · Fixed by #207
Assignees
@ThomasAdam
Labels
type:bug Something's broken!
Milestone
1.0.1

Comments

@afhp-2020
Copy link

I saw the release of 1.0, so I cloned the repository into a new directory and started building.

The first run of ./autogen.sh complained about libbson, so the package was installed. The second run completed without error. There is no error reported by ./configure either.

make fails with:

 FvwmMFL.c:30:10: fatal error: 'bson/bson.h' file not found
 #include <bson/bson.h>

Build system is FreeBSD 12.1-RELEASE-p5 with all packages up-to-date as of 2020-09-03.

configure.log
make.log
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.88. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the type:bug Something's broken! label Sep 3, 2020
@ThomasAdam
Copy link
Member

I wonder if this is libbson/bson.h versus just bson.h? Can you try making that change to FvwmMFL.c?

@afhp-2020
Copy link
Author

Now that you pointed me in the right direction...

Replacing the include with libbson/bson.h also failed.

However, pkg info -l libbson yields

[...8<...]
/usr/local/include/libbson-1.0/bson.h
[...>8...]

So, replacing the include with libbson-1.0/bson.h seems to fix the issue.

I suspect some special case will be needed in configure or an ifdef or something similar, so I'll re-test with a full build whenever ready.

Regards,
A.

@ThomasAdam
Copy link
Member

Cool. That's annoying as I tested an older version of FreeBSD.

Keep that patch for now, and let me know of any functional problems instead.

@ThomasAdam ThomasAdam added this to the post-1.0 milestone Sep 3, 2020
ThomasAdam added a commit that referenced this issue Sep 5, 2020
@ThomasAdam
FvwmMFL: libbson: guard for FreeBSD
f230425 
FreeBSD has bson.h in a different location than pkg-config expects.  For
now, guard against this with #ifdef.

Fixes #200
@ThomasAdam ThomasAdam mentioned this issue Sep 5, 2020
Merged
@ThomasAdam
Copy link
Member

Hi @afhp-2020,

Please take a look at the linked PR, and let me know if this fixes your issue.

Thanks,
Thomas

@ThomasAdam ThomasAdam self-assigned this Sep 5, 2020
@ThomasAdam ThomasAdam modified the milestones: post-1.0, 1.0.1 Sep 5, 2020
@afhp-2020
Copy link
Author

Hello Thomas,

Sorry for the delay.

I just pulled ta/gh-200 and it built without error.

Regards,
A.

ThomasAdam added a commit that referenced this issue Sep 10, 2020
@ThomasAdam
FvwmMFL: libbson: guard for FreeBSD
030c999 
FreeBSD has bson.h in a different location than pkg-config expects.  For
now, guard against this with #ifdef.

Fixes #200
@afhp-2020 afhp-2020 mentioned this issue Oct 19, 2020
Closed
mikeandmore pushed a commit to mikeandmore/fvwm3 that referenced this issue Nov 28, 2020
@ThomasAdam @mikeandmore
FvwmMFL: libbson: guard for FreeBSD
7f0e437 
FreeBSD has bson.h in a different location than pkg-config expects.  For
now, guard against this with #ifdef.

Fixes fvwmorg#200
@ThomasAdam ThomasAdam moved this to Done in FVWM3 Sep 18, 2022
@ThomasAdam ThomasAdam added this to FVWM3 Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasAdam ThomasAdam

Labels
type:bug Something's broken!
Projects
FVWM3
Status: Done
Milestone
1.0.1
Development

Successfully merging a pull request may close this issue.

FvwmMFL: libbson: guard for FreeBSD fvwmorg/fvwm3
2 participants
@ThomasAdam @afhp-2020