-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SkipMapping disables StartsOnPage/StartsOnDesk #373
Comments
When updating the desk which a window is on, don't be so clever about updating the currentdesk if it's the same as the screen. Other parts of fvwm3 will be setting this conditionally for their own reasons, and this check was clobbering that (such as in placement.c for StartsOnDesk style). Fixes #373
Hi @slalik Thanks! Please see the PR referenced here -- for reference, please checkout the Just FYI (since you mention it), I will be removing the Xrm method of being able to tell |
I applied the patch to released version 1.0.2. The result is the following. I have 2 monitors. They are configured by the command
There is nothing about dual monitors in the fvwm config. After the patch, StartsOnPage is respected then a program starts from the prime monitor and ignored if it starts from the second monitor. I checked for several programs. Should I also checked |
Can you provide more information here? What do you mean? If you're wanting a specific style to apply to a specific screen, then you can use:
|
I did more experiments and I see that it depends on the cursor position. For example, I have
If I start xeyes when the mouse cursor is on Desk0 on left (prime) monitor, xeyes start on Desk1, if the cursor is on Desk0 on the right monitor, xeyes start on Desk0. I even tried to disable mouse with
The result is the same depends on the cursor position at the moment of disabling. |
Hi @slalik Yes, this is expected. If you use Either way, my original patch seems to have fixed your problem, yes? |
Yes,
works, so the problem is fixed. Thank you! |
When updating the desk which a window is on, don't be so clever about updating the currentdesk if it's the same as the screen. Other parts of fvwm3 will be setting this conditionally for their own reasons, and this check was clobbering that (such as in placement.c for StartsOnDesk style). Fixes #373
I noticed a regression in version 1.0.2: with SkipMapping style, StartsOnPage/StartsOnDesk stop working.
I take the config
If I add
Style xterm StartsOnPage 1
it works as expected, xterm starts on Desk1.
But if I add
Style xterm SkipMapping, StartsOnPage 1
xterm starts on Desk0
Moreover, if I add
Style xterm SkipMapping
and run
xterm -xrm "*Desk:1"
it starts on Desk0.
Without
Style xterm SkipMapping
xterm -xrm "*Desk:1"
works as expected.
There was no this problem in version 1.0.1.
Fvwm3 version
fvwm3 1.0.2 (released)
with support for: ReadLine, XPM, PNG, SVG, Shape, XShm, SM, Bidi text, XRandR, XRender, XCursor, XFT, NLS
Linux distribution
Slackware 14.2
Platform
Linux Intel(R) Xeon(R) CPU E3-1275 v5 @ 3.60GHz
The text was updated successfully, but these errors were encountered: