Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartsOnPage/StartsOnDesk ignored #39

Closed
afhp-2020 opened this issue Mar 31, 2020 · 5 comments
Closed

StartsOnPage/StartsOnDesk ignored #39

afhp-2020 opened this issue Mar 31, 2020 · 5 comments
Assignees
Labels
type:bug Something's broken!
Milestone

Comments

@afhp-2020
Copy link

Hello,

Using a config file I am adapting and correcting from fvwm2, I came across a regression regarding forced window placement on a given desktop.
Configuration is explicitely declared global (but it makes no difference) :
DesktopConfiguration global

I do not use pages, and 4 desktops are defined:

DesktopSize 1x1
DesktopName 0 Net
DesktopName 1 Dev
DesktopName 2 MM
DesktopName 3 Misc
EdgeScroll 0 0
EdgeThickness 0

Multimedia applications are set to open on Desktop 2:

Style vlc StartsOnPage 2
Style mpv StartsOnPage 2

(StartsOnDesk 2 does no better)

Opening any application defined as above to open on a given desk results in the application actually opening on the current active desk.

This configuration was working as expected under fvwm2.

It should be noted that StartsOnScreen on the other hand works as documented.

@ThomasAdam
Copy link
Member

Hi,

Yes, you're right. Probably related to #22.

@ThomasAdam
Copy link
Member

ThomasAdam commented Apr 6, 2020

Can you retest this, please? I've tested this with:

Style xeyes StartsOnScreen HDMI2, StartsOnPage 1 1, SkipMapping

... and starting xeyes: xeyes +shape puts that window on Page 1 1, on my second screen (which is not considered the active screen; that is, my mouse pointer is on a different monitor) -- so this is working OK.

You should build fvwm3 on the ta/gh-22 branch.

Please confirm.

@afhp-2020
Copy link
Author

Hello,

Not yet entirely familiar with git ; did a git pull origin ta/gh-22, recompiled, reinstalled and restarted from display manager.
(Note: compiling and installing with make ; sudo make install on FreeBSD, compiles and installs without error. Thanks for keeping the code system- and make-agnostic.)

Testing with current configuration elements, as in Style mpv StartsOnPage 2, as well as variations on your style definition above, in succession:

Style xeyes StartsOnScreen DP-2, StartsOnDesk <n> : as before, Screen is respected, Desk is ignored, the window appears on the current desk. Same with StartOnPage <n>.

Since I am not using pages, StartsOnPage with non-zero 2nd and/or 3rd argument obviously cause the window to not be shown. Otherwise, same behavior, the window appears on the current desk regardless of the first argument.

The presence or absence of SkipMapping has no effect.

ThomasAdam added a commit that referenced this issue Apr 10, 2020
When updating which screen a window is on, don't trample over the Desk
which has already been set via things like StartsOn{Page,Desk}.
Otherwise, the window's intended desk is overwritten with the current
desk which is almost never what the user menat.

Fixes #39
@ThomasAdam
Copy link
Member

Hi @afhp-2020

Really fixed this time. Please git pull on ta/gh-22 as you've been doing and try again!

This is working for me:

Style xeyes StartsOnDesk 4

@ThomasAdam ThomasAdam added this to the 1.0 milestone Apr 10, 2020
@ThomasAdam ThomasAdam added the type:bug Something's broken! label Apr 10, 2020
@ThomasAdam ThomasAdam self-assigned this Apr 10, 2020
@afhp-2020
Copy link
Author

Got lost in git merge so I re-cloned master and re-pulled ta/gh-22 again.

I am happy to report that the issue is fixed.

Style xeyes StartsOnDesk <n> issued at FvwmConsole, starting xeyes opens it on the specified desktop.
Similarly with existing Style <application> StartsOnPage 2 in config file, specified applications open where expected.

ThomasAdam added a commit that referenced this issue Apr 29, 2020
When updating which screen a window is on, don't trample over the Desk
which has already been set via things like StartsOn{Page,Desk}.
Otherwise, the window's intended desk is overwritten with the current
desk which is almost never what the user menat.

Fixes #39
mikeandmore pushed a commit to mikeandmore/fvwm3 that referenced this issue Nov 28, 2020
When updating which screen a window is on, don't trample over the Desk
which has already been set via things like StartsOn{Page,Desk}.
Otherwise, the window's intended desk is overwritten with the current
desk which is almost never what the user menat.

Fixes fvwmorg#39
@ThomasAdam ThomasAdam moved this to Done in FVWM3 Sep 18, 2022
@ThomasAdam ThomasAdam added this to FVWM3 Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something's broken!
Projects
Status: Done
Development

No branches or pull requests

2 participants