Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some files/dirs not removed by make uninstall #422

Closed
djwf opened this issue Feb 3, 2021 · 0 comments · Fixed by #496
Closed

Some files/dirs not removed by make uninstall #422

djwf opened this issue Feb 3, 2021 · 0 comments · Fixed by #496
Labels
difficulty:easy Issue is suitable for new fvwm developer type:bug Something's broken!
Milestone
1.0.3

Comments

@djwf
Copy link
Contributor

djwf commented Feb 3, 2021 •
edited
Loading

Version: Latest master (commit 1164090)
Distribution: Debian testing
Platform: Linux looh 5.10.0-2-amd64 #1 SMP Debian 5.10.9-1 (2021-01-20) x86_64 GNU/Linux

When executing make uninstall the following files were not removed:

/usr/local/share/fvwm3/FvwmScript-ConfirmCopyConfig
/usr/local/share/fvwm3/FvwmScript-ConfirmQuit
/usr/local/share/fvwm3/FvwmScript-DateTime

Also, the following directories were not removed:

/usr/local/libexec/fvwm3/1.0.3
/usr/local/share/fvwm3

I expect this is just an oversight in the Makefile, but I'm not sure how to fix it.

To reproduce this, run make install, then make uninstall.
@djwf djwf added the type:bug Something's broken! label Feb 3, 2021
@djwf djwf changed the title Some files/dirs not removed by make uninstall Some files/dirs not removed by make uninstall Feb 3, 2021
@ThomasAdam ThomasAdam added the difficulty:easy Issue is suitable for new fvwm developer label Feb 3, 2021
@ThomasAdam ThomasAdam added this to the 1.0.3 milestone Feb 3, 2021
@somiaj somiaj mentioned this issue May 25, 2021
Merged
somiaj pushed a commit that referenced this issue May 25, 2021
Ensure make uninstall removes default-config links.
b33375d 
Update make uninstall to remove the FvwmScript links from the
default-config from $FVWM_DATADIR and remove both
FVWM_MODULEDIR and FVWM_DATADIR if empty. Closes #422
ThomasAdam pushed a commit that referenced this issue May 25, 2021
@ThomasAdam
Ensure make uninstall removes default-config links.
be363b7 
Update make uninstall to remove the FvwmScript links from the
default-config from $FVWM_DATADIR and remove both
FVWM_MODULEDIR and FVWM_DATADIR if empty. Closes #422
@ThomasAdam ThomasAdam added this to FVWM3 Sep 18, 2022
@ThomasAdam ThomasAdam moved this to Done in FVWM3 Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy Issue is suitable for new fvwm developer type:bug Something's broken!
Projects
FVWM3
Status: Done
Milestone
1.0.3
Development

Successfully merging a pull request may close this issue.

Ensure make uninstall removes default-config links. fvwmorg/fvwm3
2 participants
@djwf @ThomasAdam