-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fvwm/session.c has left FVWM_SM_DEBUG_FILES enabled #480
Comments
Hi @pm215 It's a little dirty, but very useful for debugging, which is why I probably left it enabled all those years ago. We could probably harden the |
I'd definitely rather my window manager wasn't writing debug info to fixed-filename temporary files in /tmp. If these have a good purpose they ought to be somewhere fvwm-specific, surely ? |
Then we should change it to be relative to |
When session state is being stored, the debug macro would copy over these files to /tmp. The security-conscious would say this is risky, especially since system() is being used. For now, completely remove this, and if there's any further debugging required, some other mechanism can be used. Fixes #480
I'm just going to remove this for now -- if we ever need to do anything else, we can code for that. |
When session state is being stored, the debug macro would copy over these files to /tmp. The security-conscious would say this is risky, especially since system() is being used. For now, completely remove this, and if there's any further debugging required, some other mechanism can be used. Fixes #480
In fvwm/session.c the debug definition FVWM_SM_DEBUG_FILES is defined, which means that whenever it saves or reloads window states it copies state files into /tmp/fs-save and /tmp/fs-load directories.
This seems to me like an accidentally left-enabled bit of debug (it was enabled in commit 974902a in 2016, and that commit's commit message doesn't mention enabling the debug as a deliberate choice).
Should the #define be commented out like the other FVWM_SM_DEBUG* lines ?
(I noticed this because the system() calls in the debug code trigger a compile warning because they don't do anything with the return value from system().)
The text was updated successfully, but these errors were encountered: