FvwmPrompt quoting not consistent with the Read command. #662
Comments
|
I will add my voice to this issue, and note that it prevents using FvwmPrompt as a direct replacement for FvwmConsole. I'm accustomed to doing things such as changing a menu definition in my .fvwm/config, opening a FvwmConsole, and pasting the new definition into FvwmConsole to refresh my live session without a full restart. The FvwmPrompt quoting issue means that this doesn't work. |
ThomasAdam
added a commit
that referenced
this issue
Aug 30, 2023
When dealing with input entered into FvwmPrompt, using shell.c.Args meant
that the input had been parsed, which doesn't preserve quotes. Hence,
the following:
Exec exec xterm -T "Foo Bar" -e mc
Was parsed as this:
Exec exec xterm -T Fooo Bar -e mc
Which is not the same thing.
It turns out that ishell preserves the argument list in RawArgs in its
context struct, so use this when parsing input from the user.
Fixes #662
|
Hi, Please have a look at the |
|
In some quick testing for me, the change from this branch fixes this issue. |
|
Thanks, @siebenmann -- that's good enough for me. Will merge. |
ThomasAdam
added a commit
that referenced
this issue
Aug 31, 2023
When dealing with input entered into FvwmPrompt, using shell.c.Args meant
that the input had been parsed, which doesn't preserve quotes. Hence,
the following:
Exec exec xterm -T "Foo Bar" -e mc
Was parsed as this:
Exec exec xterm -T Fooo Bar -e mc
Which is not the same thing.
It turns out that ishell preserves the argument list in RawArgs in its
context struct, so use this when parsing input from the user.
Fixes #662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
$ fvwm3 --version
fvwm3 1.0.5 (1.0.4-123-g0fe58f0d-dirty)
with support for: ReadLine, XPM, PNG, SVG, Shape, XShm, SM, Bidi text, XRandR, XRender, XCursor, XFT, NLS
A new ~amd64 gentoo installation.
$ uname -sp
Linux Intel(R) Core(TM) i7-2600 CPU @ 3.40GHz
Expected Behaviour
FvwmPront should use the same quoting than into the files read by the Read command.
If I write
Exec urxvt -name "Some name" -e mcinto a file and read it withRead thefile, it work fine and the resource of the urxvt window is "Some name".If I write the same at the FvwmPrompt prompt, mc start but the resource of the urxvt window is truncated to "Some".
Into the log, I get
urxvt: "name": malformed option.In order to get the resource string I want, I must write
Exec urxvt -name \"Some name\" -e mcThat is not consistent and can cause a lot of confusion for newcomers.
I get the same issue with Style options like
Style "ALSA Mixer card $[infostore.SoundCard]" !IconNo.
Include your configuration with this issue.
That's fvwm-crystal git with some work in progress in $[FVWM_USERDIR].
The text was updated successfully, but these errors were encountered: