Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WindowName option to FvwmButtons #219

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

NsCDE
Copy link
Contributor

@NsCDE NsCDE commented Sep 9, 2020

Hi,

Today I have adapted "WindowName" FvwmButtons patch for FVWM3, together with man page entry.
I have been using it with FVWM2 for 1-2 years already.

This adds functionality for subpanels which intentionally have Title (like CDE Front Panel
and it's subpanels as you can guess) with non-ASCCI characters and spaces, which cannot be
accomplished with FvwmButtons module alias.

@ThomasAdam
Copy link
Member

Hi @NsCDE,

This looks good. I'm note sure char windowname[128]; is necessarily long enough, but I suppose it will do for now. One suggestion:

diff --git a/modules/FvwmButtons/parse.c b/modules/FvwmButtons/parse.c
index 394399518..dac8f2b44 100644
--- a/modules/FvwmButtons/parse.c
+++ b/modules/FvwmButtons/parse.c
@@ -1946,10 +1946,7 @@ static void ParseConfigLine(button_info **ubb, char *s)
                        ub->c->flags.b_WindowName = 0;
                }
 #ifdef DEBUG_PARSER
-               if (windowname == 0)
-               {
                        fprintf(stderr, "%s\n", windowname);
-               }
 #endif
                break;
        }

@NsCDE
Copy link
Contributor Author

NsCDE commented Sep 9, 2020

Hi,

Removed unnecessary if (windowname ... and resubmitted.

@ThomasAdam ThomasAdam merged commit d885daa into fvwmorg:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants