Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix window locations in Global mode #237

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Fix window locations in Global mode #237

merged 3 commits into from
Sep 30, 2020

Conversation

ThomasAdam
Copy link
Member

Fix the locations of windows when in global mode.

Previous to this change, only windows on the active monitor were being
updated, leading to inconsistencies in where the windows were being placed.

  • FvwmPager: respect DesktopConfiguration setting
  • FvwmPager: list_new_desk: use this monitor
  • global mode: track virtual_scr across all monitors

@ThomasAdam
FvwmPager: respect DesktopConfiguration setting
918698e 
When FvwmPager is launched without a "Monitor" config, it assumes the
remit is global -- that is, it will show windows from all monitors.
However, this could be at odds with the DesktopConfiguration setting.

When FvwmPager performs tasks such as switching pages and/or desks, it
does so by sending Fvwm commands directly.  This includes monitor
information which is not what's needed if DesktopConfiguration is
global.

Therefore, only send the monitor string across if FvwmPager is already
tracking a specific monitor.

Helps with #236
@ThomasAdam
FvwmPager: list_new_desk: use this monitor
15e003f 
When listing the new desk, don't try and compare a module's output, but
rather reuse the existing fpmonitor_this() function.

Fixes #236

(cherry picked from commit 57dc6da)
@ThomasAdam
global mode: track virtual_scr across all monitors
a66660d 
When "DesktopConfiguration global" is used, keep in sync the
virtual_scr struct so that this doesn't clash for commands which assume
per-monitor.

Fixes #236
@ThomasAdam ThomasAdam linked an issue Sep 30, 2020 that may be closed by this pull request
DesktopConfiguration global inherits behaviour from per-monitor mode #236
Closed
@ThomasAdam ThomasAdam added this to the 1.0.1 milestone Sep 30, 2020
@ThomasAdam ThomasAdam added the type:bug Something's broken! label Sep 30, 2020
@ThomasAdam ThomasAdam self-assigned this Sep 30, 2020
@ThomasAdam ThomasAdam merged commit e557dd3 into master Sep 30, 2020
@ThomasAdam ThomasAdam deleted the ta/gh-236 branch September 30, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ThomasAdam ThomasAdam

Labels
type:bug Something's broken!
Projects
FVWM3
Status: Done
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.

DesktopConfiguration global inherits behaviour from per-monitor mode
1 participant
@ThomasAdam