Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Python 3 based FvwmCommand compatibility script #337

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Introduce Python 3 based FvwmCommand compatibility script #337

merged 1 commit into from
Dec 9, 2020

Conversation

NsCDE
Copy link
Contributor

@NsCDE NsCDE commented Dec 9, 2020

Here it is.

ThomasAdam
ThomasAdam requested changes Dec 9, 2020
View reviewed changes
Copy link
Member

@ThomasAdam ThomasAdam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NsCDE

This looks really good! Thanks ever so much. A few comments inline -- one about import json and a few suggestions on the autotools stuff.

Oh -- can you also change your commit message body to explain why we're adding FvwmCommand, and which bug it fixes. You can have this as the last line in your message:

Fixes #XXX

... where "XXX" is the bug number. This will tie everything together and help with generating the Changelog.

bin/FvwmCommand.in Show resolved Hide resolved
bin/FvwmCommand.in Show resolved Hide resolved
bin/FvwmCommand.in Outdated Show resolved Hide resolved
bin/FvwmCommand.in Outdated Show resolved Hide resolved
bin/Makefile.am Outdated Show resolved Hide resolved
@NsCDE
Copy link
Contributor Author

NsCDE commented Dec 9, 2020

Yes yes, no problem.

PFA revisited PR Sir.

@ThomasAdam
Copy link
Member

Hi @NsCDE

Thanks. This looks good. I'd still like to see the commit message read like:

FvwmCommand: rework for FvwmMFL

When FvwmCommand was removed in favour of using FvwmPrompt, there was no legacy wrapper for maintaing FvwmCommand.

Reintroduce this as a wrapper against FvwmMFL.

Fixes #312

@NsCDE
FvwmCommand: rework for FvwmMFL
d4a8266 
When FvwmCommand was removed in favour of using FvwmPrompt, there was no legacy wrapper for maintaing FvwmCommand.
Reintroduce this as a wrapper against FvwmMFL.
Fixes fvwmorg#312
@ThomasAdam ThomasAdam linked an issue Dec 9, 2020 that may be closed by this pull request
Lack of FvwmCommand can break existing configuration #312
Closed
@ThomasAdam ThomasAdam merged commit e1eae74 into fvwmorg:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasAdam ThomasAdam ThomasAdam requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lack of FvwmCommand can break existing configuration
2 participants
@NsCDE @ThomasAdam