Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config parsing: be more tolerant when finding configs #353

Merged
merged 1 commit into from
Dec 13, 2020

Conversation

ThomasAdam
Copy link
Member

When looking for which config file to load by default (that is, without
invoking fvwm with '-f'), there is a long compatibility list of file
locations to look through.

Fix an off-by-one error in array assignment, and also break out of the
compatibility loop once we have found a config file to load -- we don't
want to clobber that file by continuing down the list; the first match
always wins, which for most people will be ~/.fvwm/config

Noticed by Brandon Martin (codedmart) on #fvwm IRC.

When looking for which config file to load by default (that is, without
invoking fvwm with '-f'), there is a long compatibility list of file
locations to look through.

Fix an off-by-one error in array assignment, and also break out of the
compatibility loop once we have found a config file to load -- we don't
want to clobber that file by continuing down the list; the first match
always wins, which for most people will be ~/.fvwm/config

Noticed by Brandon Martin (codedmart) on #fvwm IRC.
@ThomasAdam ThomasAdam added this to the 1.0.2 milestone Dec 13, 2020
@ThomasAdam ThomasAdam self-assigned this Dec 13, 2020
@ThomasAdam ThomasAdam merged commit 3daefee into master Dec 13, 2020
@ThomasAdam ThomasAdam deleted the ta/fix-config-finding branch December 13, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant