Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to FvwmPager scaling math to improve visual aspects due to rounding errors. #790

Merged
merged 2 commits into from
Jan 2, 2023
Merged

Updates to FvwmPager scaling math to improve visual aspects due to rounding errors. #790

merged 2 commits into from
Jan 2, 2023

Commits on Jan 2, 2023

  1. Update math to scale windows in FvwmPager. 

      When computing the position and size of a scaled window in FvwmPager,
  compute the position of all four edges instead of the top/left corner
  and the width/height. This makes it so when rounding the bottom/right
  edge position, it is the same for all windows at the same position with
  different sizes. This makes the round issues less visible and removes
  off by one pixel issues in many cases (especially for small pagers).

  This also cleans up the function which scales the window along with
  removing an unneeded variable from the stack.
    @somiaj
    somiaj committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    8ff4f99 View commit details
    Browse the repository at this point in the history

  2. Update math for size/location of FvwmPager viewport. 

      When computing the size and location of the FvwmPager view port
  for the current page, compute the position of all four edges
  instead of the top/left position and height/width. This makes it
  so any rounding do to scaling is consistent with DrawGrid(), and
  fixes some off by one pixel issues with the view port and the grid
  on small pagers whose size is not even multiples of the number of
  pages (which is now possible since size hints were removed).
    @Cigaes @somiaj
    Cigaes authored and somiaj committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    6da100c View commit details
    Browse the repository at this point in the history