Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor: fix geometry parsing for window assignment #889

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

ThomasAdam
Copy link
Member

@ThomasAdam ThomasAdam commented Aug 30, 2023

When updating which monitor a window is on, use the g.max or g.normal structures directly.

@ThomasAdam ThomasAdam added this to the 1.0.8 milestone Aug 30, 2023
@ThomasAdam ThomasAdam self-assigned this Aug 30, 2023
@ThomasAdam ThomasAdam removed this from the 1.0.8 milestone Sep 4, 2023
When updating which monitor a window is on, don't call
get_unshaded_geometry() as the window's coordinates are already relative
to where it is.

Instead, use either the maximized frame or the normal frame.

Fixes #608
@ThomasAdam ThomasAdam marked this pull request as ready for review December 12, 2023 07:07
@ThomasAdam ThomasAdam added the type:bug Something's broken! label Dec 12, 2023
@ThomasAdam ThomasAdam added this to the 1.1.0 milestone Dec 12, 2023
@ThomasAdam ThomasAdam changed the title WIP: maybe fix 608 monitor: fix geometry parsing for window assignment Dec 12, 2023
@ThomasAdam ThomasAdam merged commit 6559365 into main Dec 12, 2023
5 checks passed
@ThomasAdam ThomasAdam deleted the ta/gh-608 branch December 12, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something's broken!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant