A few FvwmPager fixes #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ThomasAdam
commented
Mar 30, 2024
ThomasAdam
commented
- Use {Min,Max}Size for the default rectangle, so that windows do not have zero size.
- Track disabled monitors if monitor_to_track was previously set.
- Free malloc()d variables on exiting the pager.
First, this fixes an issue if monitor_to_track is set and that monitor is disconnected, then fvwm pager stops tracking anything. Instead, if monitor_to_track is disconnected, monitor_to_track will switch to the current monitor instead. If that monitor is enabled again, fvwm will resume tracking it.
Allowing the height or width of a window to become zero can causes them to misbehave (noticed this when switching between monitors). Use MinSize instead of zero for windows in this case.
When the FvwmPager is closed/killed, ensure we free some of the variables which had been malloc()d.
ThomasAdam
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.