Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for Diagnose and DiagnoseFirst #405

Merged
merged 1 commit into from
May 15, 2023
Merged

Add more tests for Diagnose and DiagnoseFirst #405

merged 1 commit into from
May 15, 2023

Conversation

fxamacker
Copy link
Owner

Add more tests and some minor refactoring by moving some subtests to its own test function.

@fxamacker fxamacker added the tests Unit tests label May 15, 2023
x448
x448 approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@x448 x448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The CI error seems like a GitHub bug because it's running old & new versions of ci-go-cover.yml.

The new (current) version of workflow passes but the replaced version (which doesn't exist anymore) is somehow running and failing. 🤯

@fxamacker fxamacker merged commit cdd8c70 into master May 15, 2023
@fxamacker fxamacker deleted the fxamacker/increase-test-coverage branch June 18, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x448 x448 x448 approved these changes

Assignees
No one assigned
Labels
tests Unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @x448