Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ignored UTF8 setting in diagMode() #417

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Remove ignored UTF8 setting in diagMode() #417

merged 1 commit into from
Jul 30, 2023

Commits on Jul 30, 2023

  1. Remove ignored UTF8 setting in diagMode() 

    Unreleased functions Diagnose() and DiagnoseFirst() added in v2.5.0-beta3
were ignoring the setting of DecOptions.UTF8 = DecodeInvalidUTF8 in
the underlying decoder.

Given this, removing the ignored code is enough to make the new
diagnostic functions match the default behavior of CBOR decoder
which is to reject invalid UTF-8 in CBOR text strings.

For now, it doesn't make sense to print invalid UTF-8 text
because the Diagnostic Notation described by RFC 8949 and the
Extended Diagnostic Notation in Appendix G of RFC 8610 don't specify
how to represent invalid UTF-8.
    @fxamacker
    fxamacker committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    09ebf1b View commit details
    Browse the repository at this point in the history