Enable more linters in .golangci.yml #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@x448 PTAL |
Remove hardcoded number of linters since that can change.
x448
approved these changes
Mar 10, 2024
benluddy
reviewed
Mar 11, 2024
| @@ -26,7 +26,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [macos-latest, ubuntu-latest, windows-latest] | |||
| go-version: [1.17, 1.19, '1.20', 1.21] | |||
There was a problem hiding this comment.
@fxamacker Did you intend to remove 1.21 here?
There was a problem hiding this comment.
@benluddy Good catch! 👍 Yes, I replaced 1.21 with 1.22 here with the intention of using 1.21 more extensively than the other versions but didn't finish refactoring workflows on Sunday.
I'll open issue so I don't forget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 7 more linters in .golangci.yml. While at it, updated some linter settings and use go1.22 in ci.yml.
I can remove goconst, etc. or relax settings if a linter gets too noisy.