Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint from 1.53.3 to 1.54.2 #543

Merged
merged 2 commits into from
May 28, 2024

Conversation

fxamacker
Copy link
Owner

@fxamacker fxamacker commented May 28, 2024

Bump golangci-lint to 1.54.2 and update .golangci.yml.

@fxamacker fxamacker added the CI CI using GitHub Actions Workflow label May 28, 2024
@fxamacker fxamacker self-assigned this May 28, 2024
@fxamacker
Copy link
Owner Author

@x448 Good catch! I'll open a PR tonight (last PR for Memorial Day spring cleaning). #542 (comment)

@x448 PTAL

@@ -17,9 +17,9 @@ on:

env:
GO_VERSION: '1.20'
GOLINTERS_VERSION: 1.53.3
GOLINTERS_VERSION: 1.54.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not bump to 1.56.2?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not bump to 1.56.2?

I was already using 1.54.2 locally and it passed all lints including go-critic. Maybe newer version next weekend.

@fxamacker fxamacker merged commit c8b278f into master May 28, 2024
17 checks passed
@fxamacker fxamacker deleted the fxamacker/bump-golangci-lint-to-1.54.2 branch September 7, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI using GitHub Actions Workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants