Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haskell support added, Bugs fixed in the case of Azure_OpenAI #28

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

Nisarg1112
Copy link
Contributor

  1. In the case of Azure_OpenAI - Some bugs are fixed
  2. Added support of Haskell language
  3. Added support of Haskell language in text_splitter module of Langchain. PR for the same - Langchain/New-feature: Added Haskell support in langchain.text_splitter module langchain-ai/langchain#16191

@fynnfluegge
Copy link
Owner

fynnfluegge commented Jan 18, 2024

@Nisarg1112 Great work, thanks a lot! Will wait for the merged PR in langchain and merged this then! :)

Edit: Nevermind, merged! Will release this when langchain PR is merged.

@fynnfluegge fynnfluegge merged commit f6f3907 into fynnfluegge:main Jan 18, 2024
@fynnfluegge
Copy link
Owner

Hey @Nisarg1112 I just checked your PR on langchain. Would recommend to remove all the trailing comma. Maybe your linter has a different setting, but to get things merged asap best practise is to keep the linter rules from the base repo 🙂
Screenshot 2024-01-20 at 19 15 41

@Nisarg1112
Copy link
Contributor Author

Hey, @fynnfluegge Sorry I missed these comments!

Sure it makes sense to remove trailing commas.
Right now it's already approved actually.

Also, Thanks for merging my PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants