-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump OAPI 2 to OAPI3 (Autogenerated) #143
Conversation
Will need to check and verify before merging as the changes are extensive
@susheel , the last time I remember us talking about upgrading to OAPI3, we didn't know how to get the auto-generated documentation to work, so we decided to stick with OAPI2. Has that been resolved? (I'm guessing not, since the Travis CI checks failed, but maybe those are unrelated errors?). Adding @jaeddy in case he remembers more about the details. |
Yep, I see this error in the travis CI build log:
@susheel I'm assuming you bumped the version to 3 so you could use this construct to extend service-info: "Your OAS 3 API might want to define additional service information as well. To do that, use the allOf OAS 3 construct." Is that right? |
@briandoconnor Yes, we needed to bump it to OAPI3 to support the We may need to bump the travis build packages to OAPI3 too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@susheel , I understand that OAPI 3 supports some new features. However, at least last time we looked at it, it also broke the auto-generated documentation, so we decided not to take advantage of those new features. Not a great choice to have to make, but until it's resolved, we either have to find a whole new way of keeping our documentation up to date, or stick with OAPI 2. @jaeddy may remember more details.
However we resolve, we need to make sure we'll have clean updated documentation before merging this in.
Hey @susheel, @dglazer — I've been working on a little tool for the past few months that would replace swagger2markup (no support for OpenAPI 3.0) with ReDoc and/or Sphinx+ReadTheDocs. This would also address some of our build issues (and vulnerability warnings) by moving that logic to an independent package. It's been a while since I've been able to make progress on the tool, but I'll discuss with another engineer on my team and see if he can pick up the remaining development to get something working. Once we get those changes made, it'd be great to review and merge this PR. |
Will need to check and verify before merging as the changes are extensive.
This is a dependency to set up the service-info PR #144