Skip to content

Commit

Permalink
added ci step to verify the fix
Browse files Browse the repository at this point in the history
  • Loading branch information
gaaclarke committed Aug 30, 2023
1 parent 8e080e3 commit 85d7586
Showing 1 changed file with 20 additions and 1 deletion.
21 changes: 20 additions & 1 deletion testing/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ def make_test(name, flags=None, extra_env=None):
'METAL_DEBUG_ERROR_MODE': '0', # Enables metal validation.
'METAL_DEVICE_WRAPPER_TYPE': '1', # Enables metal validation.
})
# Impeller tests are only supported on macOS for now.

run_engine_executable(
build_dir,
'impeller_unittests',
Expand All @@ -508,6 +508,25 @@ def make_test(name, flags=None, extra_env=None):
]
)

# Run one interactive Vulkan tests with validation on.
run_engine_executable(
build_dir,
'impeller_unittests',
executable_filter,
[
'--enable_vulkan_validation', '--playground_timeout_ms=4000',
'--enable_playground', '--gtest_filter="*ColorWheel/Vulkan"'
],
coverage=coverage,
extra_env=extra_env,
# TODO(117122): Remove this allowlist.
# https://github.com/flutter/flutter/issues/114872
allowed_failure_output=[
'[MTLCompiler createVertexStageAndLinkPipelineWithFragment:',
'[MTLCompiler pipelineStateWithVariant:',
]
)


def run_engine_benchmarks(build_dir, executable_filter):
print('Running Engine Benchmarks.')
Expand Down

0 comments on commit 85d7586

Please sign in to comment.