Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamburger Menu Broken on Mobile Safari #9

Open
kerim opened this issue Mar 9, 2021 · 2 comments
Open

Hamburger Menu Broken on Mobile Safari #9

kerim opened this issue Mar 9, 2021 · 2 comments

Comments

@kerim
Copy link

kerim commented Mar 9, 2021

Thanks for this lovely theme. I'm adapting it for my own use and discovered that the hamburger navigation menu on mobile safari (I can't test Android) does not work. The menu collapses to the hamburger, but tapping it does not do anything. This is true, for instance, with your own personal site: https://gaalcaras.com/fr/

@kerim
Copy link
Author

kerim commented Mar 13, 2021

I figured this one out. In _includes/header.html you need to change line 13 from:

<span class="menu-icon">

to

<span class="menu-icon" onclick="">

@kerim
Copy link
Author

kerim commented Mar 13, 2021

I've created a pull request for this. First time I've done that on Github, so I hope I did it correctly.

noew added a commit to noew/academic that referenced this issue Dec 24, 2023
Based on this suggestion: gaalcaras#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant