minor followup to PR 7894

- add comment on why we check param when generating error log
- add unit test that covers getting name from non-string param type

rh-pre-commit.version: 2.2.0
rh-pre-commit.check-secrets: ENABLED

pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go

@@ -646,6 +646,8 @@ func resolveTask(
 			case errors.Is(err, remote.ErrRequestInProgress):
 				return rt, err
 			case err != nil:
+				// some of the resolvers obtain the name from the parameters instead of from the TaskRef.Name field,
+				// so we account for both locations when constructing the error
 				name := pipelineTask.TaskRef.Name
 				if len(strings.TrimSpace(name)) == 0 {
 					name = resource.GenerateErrorLogString(string(pipelineTask.TaskRef.Resolver), pipelineTask.TaskRef.Params)

pkg/resolution/resource/name_test.go

@@ -272,6 +272,20 @@ func TestGenerateErrorLogString(t *testing.T) {
 				},
 			},
 		},
+		{
+			name:         "goo-array",
+			resolverType: "bundle",
+			isPresent:    true,
+			params: []v1.Param{
+				{
+					Name: resource.ParamName,
+					Value: v1.ParamValue{
+						Type:     v1.ParamTypeArray,
+						ArrayVal: []string{resource.ParamName, "goo-array"},
+					},
+				},
+			},
+		},
 		{
 			name:         "hoo",
 			resolverType: "cluster",