New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wstring_view_t not defined with SPDLOG_WCHAR_FILENAMES #1249

Closed

isanae opened this issue Sep 28, 2019 · 1 comment

isanae commented Sep 28, 2019

Commit 3bcd3ce changed the #if in os.h to include SPDLOG_WCHAR_FILENAMES, but wstring_view_t in common.h is only defined for SPDLOG_WCHAR_TO_UTF8_SUPPORT.

The text was updated successfully, but these errors were encountered:

gabime added a commit that referenced this issue


          Fix issue #1249

188afe2

Owner

gabime commented Sep 28, 2019

Fixed. Thanks for reporting

gabime closed this as completed

bachittle pushed a commit to bachittle/spdlog that referenced this issue


          Update Maintainers (gabime#1249)

b46cd6f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment