Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

details\pattern_formatter-inl.h & details\thread_pool-inl.h should include <cassert> #1340

Closed
jeanga opened this issue Dec 2, 2019 · 1 comment · Fixed by msys2/MINGW-packages#6044
Closed

details\pattern_formatter-inl.h & details\thread_pool-inl.h should include <cassert> #1340

jeanga opened this issue Dec 2, 2019 · 1 comment · Fixed by msys2/MINGW-packages#6044

Comments

@jeanga
Copy link

jeanga commented Dec 2, 2019 •
edited
Loading

Hi,

When compiling spdlog (via vcpkg, with fmt 6.1.0 with VC2019 preview), I have compilation errors for details\pattern_formatter-inl.h & details\thread_pool-inl.h.

Adding #include fixes the error.

HTH,
Jean
@gabime gabime closed this as completed in 1aa9ea9 Dec 2, 2019
@gabime
Copy link
Owner

gabime commented Dec 2, 2019

Fixed. Thanks for reporting,

podsvirov added a commit to podsvirov/MINGW-packages that referenced this issue Dec 12, 2019
@podsvirov
spdlog: Rebuild
691764f 
This required for binary compatibility since dependency `fmt` package updated.
The patch `001-spdlog-1.4.2-include-cassert.patch` required to fix gabime/spdlog#1340.
@podsvirov podsvirov mentioned this issue Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spdlog: Rebuild podsvirov/MINGW-packages
2 participants
@gabime @jeanga