Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to build version 1.8.1 with msvc14 #1713

Closed
deleoDev91 opened this issue Oct 21, 2020 · 2 comments
Closed

Fail to build version 1.8.1 with msvc14 #1713

deleoDev91 opened this issue Oct 21, 2020 · 2 comments

Comments

@deleoDev91
Copy link

Hi,
Im trying to use the last version of spdlog in my project but this fails to build because in spdlog\fmt\bundled\format.h(1751) uses std copy without using (the pain in the ass) checked iterator utilities from stdext. This is only necessary when building with msvc (Im using msvc14). In error notification say that this can be solved disabling certain warnings but i dont to do this unless its totally necessary

@gabime
Copy link
Owner

gabime commented Oct 21, 2020

fmt warnings are out of the scope of spdlog repo, it belongs to fmt repo

@gabime gabime closed this as completed Oct 21, 2020
@deleoDev91
Copy link
Author

Thanks for your support, @gabime .
For now I solved the problem downloading an older version of fmt(6.0.0) and disabling the spdlog version through macro SPDLOG_FMT_EXTERNAL. I left an issue in fmt git repporting the problem. Leaving link for people who has same problem:
fmtlib/fmt#1947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants