Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unresolved symbols when moving to spdlog 1.10 without recompile - maybe full symbol #2369

Closed
commel opened this issue May 10, 2022 · 4 comments · Fixed by #2376
Closed

Unresolved symbols when moving to spdlog 1.10 without recompile - maybe full symbol #2369

commel opened this issue May 10, 2022 · 4 comments · Fixed by #2376

Comments

@commel
Copy link
Contributor

commel commented May 10, 2022

The cryfs package uses spdlog 1.8.x. openSUSE moved to spdlog 1.10. This resulted in unresolved symbols, because of a ABI break in one of the later commits: c47ae3b

Would it be possible to include version symbols in the releases? Or somehow maintain backward compatibility?

See our bugreport: https://bugzilla.opensuse.org/show_bug.cgi?id=1199306#c0

@tt4g
Copy link
Contributor

tt4g commented May 10, 2022

SPDLOG_VERSION macro is here:

#define SPDLOG_VER_MAJOR 1
#define SPDLOG_VER_MINOR 10
#define SPDLOG_VER_PATCH 0
#define SPDLOG_VERSION (SPDLOG_VER_MAJOR * 10000 + SPDLOG_VER_MINOR * 100 + SPDLOG_VER_PATCH)

@Vogtinator
Copy link

What's needed is to either increase the sover on each ABI incompatible release or introduce use of symbol versioning.

@tt4g
Copy link
Contributor

tt4g commented May 11, 2022

There is no documentation on ABI compatibility for spdlog, but I think spdlog has a policy of not guaranteeing ABI compatibility with minor version upgrades.
@gabime Is this understanding correct?

@gabime
Copy link
Owner

gabime commented May 11, 2022

We try not to break the ABI however it is certainly not guaranteed nor a top priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants