Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog: update to 1.10.0. #36533

Merged
merged 1 commit into from
May 28, 2022
Merged

spdlog: update to 1.10.0. #36533

merged 1 commit into from
May 28, 2022

Conversation

skmpz
Copy link
Contributor

@skmpz skmpz commented Apr 5, 2022

Testing the changes

  • I tested the changes in this PR: YES

@Piraty Piraty merged commit 32fed85 into void-linux:master May 28, 2022
@Johnnynator
Copy link
Member

You should always check some dependents of a library when updating it, spdlog did break ABI and therefore nheko, MangoHud, cryfs and gerbera did need to be recompiled.

@skmpz
Copy link
Contributor Author

skmpz commented May 31, 2022

hm.. correct, but out of curiosity, why aren't those listed with xbps-query -X spdlog.. Is that one only for packages that have spdlog in depends=.. ? and also, is there any other flag on xbps to detect those or just do it manually?

@Johnnynator
Copy link
Member

You need to use -RX to also list packages that aren't installed on your system.

@skmpz
Copy link
Contributor Author

skmpz commented May 31, 2022

this will also show reverse runtime dependencies though and not build dependencies right ?

$ sudo xbps-query -RX spdlog
coeurl-devel-0.1.1_1

Just wondering if there's any other way other than just grepping through the srcpkgs folder to find reverse build dependencies..

@skmpz
Copy link
Contributor Author

skmpz commented May 31, 2022

i guess xrevshlib spdlog does exactly that :).. Anyway, thanks for the input and sorry for the trouble caused.

@skmpz
Copy link
Contributor Author

skmpz commented May 31, 2022

just another question.. when getting

$ xrevshlib spdlog
Bear
coeurl
cryfs
gerbera
MangoHud
nheko
Waybar

Is there a way to figure out which packages need to be recompiled?

@Johnnynator
Copy link
Member

Ideally a package does increase the so version (the number behind .so as listed in e.g. common/shlibs in xbps-src).
spdlog did not do that in 1.10.0 ( gabime/spdlog#2369 ), but they changed their build system to also include minor version in there, so this specific issue is unlikely to happen again.

Is there a way to figure out which packages need to be recompiled?

Void currently doesn't have tooling in xbps-src to track symbols, so no automatic way for detecting this.
You (or a script) could in theory just install all of these packages and check if all the symbols do resolve.

@skmpz
Copy link
Contributor Author

skmpz commented May 31, 2022

ah ok got it.. thanks again..

@Piraty
Copy link
Member

Piraty commented May 31, 2022

@skmpz skmpz deleted the spdlog-1.10.0 branch June 17, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants