Prevent NEAR and FAR macro definitions from leaking on Windows platforms #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently encountered an issue in a project which has NEAR and FAR variables (constexpr in some namespace), after including spdlog.
Turns out that including
windows.hleaks those, and that happened transitively through spdlog.Now obviously this really is more of a Windows issue, but I think it would be convenient - especially for multi-platform users of spdlog - to prevent leakage of these symbols (with the same reasoning as e.g. for defining NOMINMAX).
The required change is rather trivial.