add max files for rotating days #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does not try to check files that exists in disk when initialization. |
gabime
requested changes
Jan 19, 2020
| using details::os::path_exists; | ||
|
|
||
| filenames_q_ = details::circular_q<filename_t>(static_cast<size_t>(max_files_)); | ||
| std::vector<filename_t> filenames; |
There was a problem hiding this comment.
This vector can be avoided. Just pushback to the q instead of accumulating in filenames.
There was a problem hiding this comment.
I think it will remove the latest log file when rotating if push back to the q directly.
I am confused whether It leads to an mistake that could not get the previews log files when service or process is restarted.
In this way it will never remove any previews files.
@gabime
bachittle
pushed a commit
to bachittle/spdlog
that referenced
this pull request
Dec 22, 2022
Co-authored-by: Reiley Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.