fix windows event sink log compilation error with UNICODE preprocessor #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You got me confused. I see you removed the |
|
I updated this PR. I'm using #ifdef to check if |
gabime
reviewed
Dec 14, 2020
| auto succeeded = ::ReportEvent(event_log_handle(), eventlog::get_event_type(msg), eventlog::get_event_category(msg), event_id_, | ||
| current_user_sid_.as_sid(), 1, 0, &lp_str, nullptr); | ||
| #ifdef SPDLOG_WCHAR_TO_UTF8_SUPPORT | ||
| auto buf = std::wstring_convert<std::codecvt_utf8<wchar_t>>().from_bytes(formatted.data()); |
There was a problem hiding this comment.
std::wstring_convert<std::codecvt_utf8> is deprecated. Please use details::os::wstr_to_utf8buf(..) instead. See usage example here.
gabime
requested changes
Dec 16, 2020
| } | ||
|
|
||
| throw_spdlog_ex(fmt::format("WideCharToMultiByte failed. Last error: {}", ::GetLastError())); | ||
| } |
There was a problem hiding this comment.
wrong error message in exception. should be “ MultiByteToWideChar”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.