Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed is_color_terminal to be more generic. #1768

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Changed is_color_terminal to be more generic. #1768

merged 1 commit into from
Dec 20, 2020

Conversation

dominicpoeschko
Copy link
Contributor

I have the issue that the in the alacritty terminal spdlog has no colors,
so I added it the the supported terminals.

To be more generic I added also a check for the COLORTERM variable
which should also indicate if the terminal supports color.

supports color.
Added alacritty to supported color terminals.
@gabime gabime merged commit adcfb7f into gabime:v1.x Dec 20, 2020
@gabime
Copy link
Owner

gabime commented Dec 20, 2020

Thanks @dominicpoeschko

@dominicpoeschko dominicpoeschko deleted the colorterminal_detection branch December 20, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants