fix bug #1790 #1906
Merged
fix bug #1790 #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabime
reviewed
Apr 5, 2021
| @@ -15,7 +15,11 @@ | |||
| // under windows using fwrite to non-binary stream results in \r\r\n (see issue #1675) | |||
| // so instead we use ::FileWrite | |||
| #include <spdlog/details/windows_include.h> | |||
|
|
|||
| #ifndef _USING_V110_SDK71_ | |||
There was a problem hiding this comment.
Please add comment about the purpose of this ifdef. It woild hard to understand without it.
There was a problem hiding this comment.
The USING_V110_SDK71 guard works when building based on a pre-8 version of Windows SDK, or trying to use the XP-toolset like vc141_xp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm also stuck at the problem described in issue #1790.
So the PR fix the problem as is in the issue, it just works.
By the way, fully remove #include <fileapi.h> is also ok, but as for the code consistency, I think keeping it is a better way.