Use std::function for the global error handler #1971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pure pointer function type error handler cannot store
lambda with capture
orstd::bind
.I think this might be a mistake? Because the error handler in
spdlog::logger
is usingerr_handler
(std::function
).This PR changes the global error handler type from a pure pointer function (
void (*)(const std::string &msg)
) toerr_handler
(std::function<void(const std::string &err_msg)>
) to fix that problem.