Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add system includes option #2575

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Feature/add system includes option #2575

merged 2 commits into from
Dec 11, 2022

Conversation

dpayne
Copy link
Contributor

@dpayne dpayne commented Dec 11, 2022

Adds support for marking include directories and system headers. This stops clang tidy (and compiler warnings) from throwing warnings when including spdlog header.

@gabime gabime merged commit edc51df into gabime:v1.x Dec 11, 2022
@gabime
Copy link
Owner

gabime commented Dec 11, 2022

Thanks @dpayne

@dpayne
Copy link
Contributor Author

dpayne commented Dec 11, 2022

that was fast, thank you!

@stertingen
Copy link

I believe this should be the default if spdlog is included via add_subdirectory or FetchContent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants