Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable systemd_sink tests in linux pipeline #2669

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

MyNameIsLame
Copy link
Contributor

As mentioned in #2668, the test_systemd.cpp tests are not build and executed in the linux pipeline, as pkg-config and libsystemd-dev packages are not installed.

In tests/CMakeLists.txt:

find_package(PkgConfig)
if(PkgConfig_FOUND)
    pkg_check_modules(systemd libsystemd)
endif()

...

if(systemd_FOUND)
    list(APPEND SPDLOG_UTESTS_SOURCES test_systemd.cpp)
endif()

By installing the two packages, the test_systemd.cpp tests should be built.

Note: Without #2668 the tests will not compile.

Without this package the test_systemd_sink.cpp will not be tested.
@gabime gabime merged commit 706ad70 into gabime:v1.x Mar 9, 2023
@gabime
Copy link
Owner

gabime commented Mar 9, 2023

Thanks @MyNameIsLame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants