Ensure marcos always expand to expressions #604
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
SPDLOG_TRACE
andSPDLOG_DEBUG
expand to nothing if they are disabled, but this can lead to problems.assert
expands to(void)0
whenNDEBUG
is defined, so I use the same here.A couple of possible problems that could happen with the current definitions:
This is valid when
SPDLOG_DEBUG_ON
is defined, but expands to,;
(which is an error) if not:If
SPDLOG_DEBUG_ON
is defined, this is a compilation error, but if not defined then then if statement actually catches the assignment tob
: