Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions on file size calculation on Windows XP x64 and Windows Server 2003 x64 #926

Merged
merged 2 commits into from
Nov 27, 2018
Merged

Conversation

lestera
Copy link
Contributor

@lestera lestera commented Nov 27, 2018

For some reason, _fstat64 fails with errno 22 on Windows Server 2003 x64 (and probably Windows XP x64 as well) when compiled using the v141_xp toolset.
Using _filelengthi64 instead solves this issue.

…machines

For some reason, `_fstat64` fails with errno 22 on Windows Server 2003 x64 when compiled using the `v141_xp` toolset.
Using `_filelengthi64` instead solves this issue
@lestera lestera changed the title Use _filelengthi64 instead of _fstat64 to calculate file size on x64 machines Fix exceptions on Windows XP x64 and Windows Server 2003 x64 Nov 27, 2018
@lestera lestera changed the title Fix exceptions on Windows XP x64 and Windows Server 2003 x64 Fix exceptions on file size calculation on Windows XP x64 and Windows Server 2003 x64 Nov 27, 2018
@gabime
Copy link
Owner

gabime commented Nov 27, 2018

Thanks !

@gabime gabime merged commit 3eba322 into gabime:v1.x Nov 27, 2018
bachittle pushed a commit to bachittle/spdlog that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants