enable reusing records in csv/tsv detection #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change should help with allocations, but ideally there would be no allocations when detecting csv. For that to happen the detection needs to move from using stdlib csv reader to something else.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #443 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 3 3
Lines 159 159
=======================================
Hits 151 151
Misses 6 6
Partials 2 2 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kodiakhq bot
referenced
this pull request
in cloudquery/plugin-pb-go
Nov 1, 2023
…#149) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/gabriel-vasile/mimetype](https://togithub.com/gabriel-vasile/mimetype) | indirect | patch | `v1.4.2` -> `v1.4.3` | --- ### Release Notes <details> <summary>gabriel-vasile/mimetype (github.com/gabriel-vasile/mimetype)</summary> ### [`v1.4.3`](https://togithub.com/gabriel-vasile/mimetype/releases/tag/v1.4.3) [Compare Source](https://togithub.com/gabriel-vasile/mimetype/compare/v1.4.2...v1.4.3) #### What's Changed - Switch csv and tsv method 'sv' from ReadAll() to stream each record with Read() by [@​splashing-atom](https://togithub.com/splashing-atom) in [https://github.com/gabriel-vasile/mimetype/pull/355](https://togithub.com/gabriel-vasile/mimetype/pull/355) - Bump golang.org/x/net from 0.8.0 to 0.17.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gabriel-vasile/mimetype/pull/441](https://togithub.com/gabriel-vasile/mimetype/pull/441) - enable reusing records in csv/tsv detection by [@​gabriel-vasile](https://togithub.com/gabriel-vasile) in [https://github.com/gabriel-vasile/mimetype/pull/443](https://togithub.com/gabriel-vasile/mimetype/pull/443) #### New Contributors - [@​splashing-atom](https://togithub.com/splashing-atom) made their first contribution in [https://github.com/gabriel-vasile/mimetype/pull/355](https://togithub.com/gabriel-vasile/mimetype/pull/355) **Full Changelog**: gabriel-vasile/mimetype@v1.4.2...v1.4.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should help with allocations, but ideally there would be no allocations when detecting csv. For that to happen the detection needs to move from using stdlib csv reader to something else.