Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mso detection work similar to what file/file does #587

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Make mso detection work similar to what file/file does #587

merged 2 commits into from
Oct 8, 2024

Commits on Oct 8, 2024

  1. Make mso detection work similar to what file/file does 

    https://github.com/file/file/blob/7c62d696b06e53fc5be015c41a57513278ac6c54/magic/Magdir/msooxml
The algorithms is not 100% percent reliable. For example, a
zero compression zip containing a docx will still sometimes be detected
as docx instead of zip (it depends on how many files and the order of
files in the zip)

Second thing in this PR is removing some test data fixtures.
From now, I'll try as much as possible to write regular unit tests
without relying on test file fixtures. #575 (comment)
related #550 #575
closes #400
    @gabriel-vasile
    gabriel-vasile committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    89677d6 View commit details
    Browse the repository at this point in the history

  2. zipContains: remove unnecessary zip sig check 

    The check is already done in parent function.
    @gabriel-vasile
    gabriel-vasile authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8c3b141 View commit details
    Browse the repository at this point in the history