Add bootstrap cli flag for create/inspect #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fizzgig1888
commented
Jun 2, 2024
| # Returns | ||
| A `python_on_whales.Builder` object. | ||
| """ | ||
| if bootstrap: |
There was a problem hiding this comment.
Note that running the docker buildx inspect --boostrap [NAME] command is necessary, when the bootstrap flag is set to True, as the command modifies the targeted builder state.
There was a problem hiding this comment.
That seems reasonable
fizzgig1888
changed the title
Fix spaces Fix missing builder
gabrieldemarmiesse
requested changes
Jul 18, 2024
| def inspect( | ||
| self, | ||
| x: Optional[str] = None, | ||
| bootstrap: Optional[bool] = False, |
There was a problem hiding this comment.
Suggested change
| bootstrap: Optional[bool] = False, | |
| bootstrap: bool = False, |
None is not an acceptable value, as such, it's not an optional.
|
Hello, and many thanks for the review and advices. Don't worry for the delay, I wasn't quick either. Two unit tests were added : test_buildx_inspect_bootstrap and test_buildx_create_bootstrap, for checking the builder bootstrap effectiveness, as you requested :) |
gabrieldemarmiesse
approved these changes
Jul 28, 2024
gabrieldemarmiesse
merged commit 682ff91
into
gabrieldemarmiesse:master
38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
The purpose of this PR is to add the hability to use the --bootstrap optional flag for the following commands :
$ docker buildx create [OPTIONS] [CONTEXT|ENDPOINT]$ docker buildx inspect [NAME]