Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Render docs" CI job #628

Merged

Conversation

LewisGaul
Copy link
Collaborator

@LewisGaul LewisGaul commented Sep 1, 2024

Hopefully fixing two issues that have started being hit in the "Render docs" CI job:

  • podman pod create failing with "initializing source docker://k8s.gcr.io/pause:3.5: Requesting bear token: invalid status code from registry 404 (Not Found)", reported at add auto/light/dark mode for docs #625 (comment) and seen in other PRs too.
    • Fixed by updating podman in the CI, since doc generation involves running podman commands.
  • ModuleNotFoundError: No module named 'griffe.collections' reported at add auto/light/dark mode for docs #625 (comment) and seen in other PRs too.
    • Fixed by updating doc package dependencies and pinning a couple more indirect dependencies (I think the lack of pinning griffe while pinning to an older version of mkdocstrings-python was the problem...).

@LewisGaul LewisGaul changed the title Update podman in docs render CI job Fix "Render docs" CI job Sep 1, 2024
@LewisGaul LewisGaul marked this pull request as ready for review September 1, 2024 17:51
@LewisGaul
Copy link
Collaborator Author

@gabrieldemarmiesse could you check the doc generation still works ok? I can't run it on my laptop since I don't have docker swarm set up. There are a bunch of warnings in the CI output about dead anchor links...

@gabrieldemarmiesse
Copy link
Owner

Thanks, I tested locally your branch (I usually disable the pods docs since I don't have podman locally) and it worked fine. Let's merge this. I still get a lot of warnings, which I believe we should fix at some point. Though it's not urgent.

@gabrieldemarmiesse gabrieldemarmiesse merged commit 9da040b into gabrieldemarmiesse:master Sep 5, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants